Skip to content

Add extra checks before querying gl calls for MSAA. #20923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
biagas wants to merge 2 commits into from
Closed

Add extra checks before querying gl calls for MSAA. #20923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9914bc5
Add extra checks before querying gl calls for MSAA.
biagas Apr 17, 2026
ff481a3
Merge branch 'develop' into bugfix/biagas/fix_startup_crash_MSAA
biagas Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions src/avt/VisWindow/Colleagues/VisWinRendering.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2756,9 +2756,26 @@ VisWinRendering::MSAAAvailable()
#if 0
#ifdef GL_MAX_SAMPLES
vtkOpenGLRenderWindow* oglWin = vtkOpenGLRenderWindow::SafeDownCast(GetRenderWindow());
if (oglWin == NULL)
return false;

// Startup can query MSAA availability before Qt/VTK has finished creating
// and binding the widget's OpenGL context. Do not issue GL calls until
// the context is current.
if (!oglWin->IsCurrent())
oglWin->MakeCurrent();

if (!oglWin->IsCurrent())
return false;

if (!oglWin->GetInitialized())
oglWin->OpenGLInit();

if (!oglWin->GetInitialized() || oglWin->GetState() == NULL)
return false;

int msamples = 0;
if(oglWin)
oglWin->GetState()->vtkglGetIntegerv(GL_MAX_SAMPLES, &msamples);
oglWin->GetState()->vtkglGetIntegerv(GL_MAX_SAMPLES, &msamples);
return (msamples > 1);
#endif
#endif
Expand Down