Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: feb56c3c61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Example apps were not part of the main CI validation path, so API drift in
examples/could slip through until someone actually ran an example. That is what happened with the staleUniformStoreusage in the cube example:yarn lintandyarn buildstayed green because they validate the packages, not the example workspaces.Solution
Add a lightweight example typecheck step as its own parallel GitHub Actions job.
Instead of bundling every example, this change adds a repo-level
examples:typecheckcommand that runstsc --noEmitagainst example workspaces. The CI wiring runs that command in a separateexamplesjob so failures are isolated from the main package/test job and do not slow down the critical path.For the initial rollout, the script targets a curated set of examples that already have clean compile coverage. That keeps CI useful immediately while avoiding unrelated legacy example type debt blocking every PR.
Changes
CI
examplesjob to.github/workflows/test.ymltestandwebsitejobs unchangedyarn install --immutableyarn examples:typecheckRepo scripts
examples:typechecktopackage.jsonExample typecheck runner
scripts/examples-typecheck.mjsexamples/*/*tsconfigper workspacetsc --noEmitfor each selected exampleScope
Validation
yarn examples:typecheckyarn lint fix