Repository navigation
Fix STL display windows and pin archived-data reader fix - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 12-month view attempted to fit seasonal STL on only 12 observations, leaving line charts without a trend and silently suppressing station trends. Fit each uninterrupted segment of the full monthly history before filtering to the selected display window. Official missing months and values remain unchanged, and segments of at most 24 observations receive no trend estimate.
Pin metrosp to the exact fix commit from viniciusoike/metrosp#35 in both renv.lock and manifest.json. This also fixes archived station-name resolution when sf is loaded. The upstream PR should be reviewed first; no package release or merge is assumed.
Validation: all five dashboard regression scripts pass together, including the September 2026 archived-data read with sf loaded. Added CI coverage for 12/24-month trend invariance, missing months/values, short segments, disabled trends, and empty station data. AIR, deployment manifest identity/coverage, and startup smoke checks pass. Browser checks show STL in the 12-month line and station views.
To verify manually, open Linhas or Estações, choose 12 meses, and enable Mostrar tendência (STL). The trend should remain visible and agree with the same dates in Desde o início.