Open
Conversation
aversecat
force-pushed
the
auke/hole_punch_ioctl_test
branch
from
19fdbf1 to
613cfce
Compare
aversecat
force-pushed
the
auke/hole_punch_ioctl_test
branch
2 times, most recently
from
787cce0 to
0397962
Compare
aversecat
force-pushed
the
auke/hole_punch_ioctl_test
branch
from
0397962 to
d624b8b
Compare
aversecat
force-pushed
the
auke/hole_punch_ioctl_test
branch
from
d624b8b to
3879728
Compare
aversecat
force-pushed
the
auke/hole_punch_ioctl_test
branch
from
3879728 to
ab3dd3f
Compare
Contributor
Author
|
retest |
1 similar comment
Contributor
Author
|
retest |
aversecat
force-pushed
the
auke/hole_punch_ioctl_test
branch
from
ab3dd3f to
250539a
Compare
Contributor
Author
|
rebased |
Contributor
Author
|
retest |
aversecat
force-pushed
the
auke/hole_punch_ioctl_test
branch
from
250539a to
03672d7
Compare
Contributor
Author
|
I went over this series another pass and found some basic gaps. Nothing crazy, but worth fixing. The changes are stacked on top of the original branch to make it easy to spot what has changed since last revision. |
Contributor
Author
|
We can squash this where needed - it can be 2-3 commits total. |
Collaborator
Yeah, agreed. It'd make sense to have 3 commits: the ioctl , the test cli command, and then the tests. |
zabbo
requested changes
Mar 13, 2026
Add an archive layer ioctl for converting offline extents into sparse extents without relying on or modifying data_version. This is helpful when working with files with very large sparse regions. Signed-off-by: Zach Brown <zab@versity.com> Signed-off-by: Auke Kok <auke.kok@versity.com>
A minimal punch_offline ioctl wrapper. Argument style is adopted from stage/release. Following the syntax for the option of stage/release, this calls the punch offline ioctl, punching any offline extent within the designated range from offset with length. Signed-off-by: Auke Kok <auke.kok@versity.com>
Basic testing for the punch-offline ioctl code. The tests consist of a bunch of negative testing to make sure things that are expressly not allowed fail, followed by a bunch of known-expected outcome tests that punches holes in several patterns, verifying them. Signed-off-by: Auke Kok <auke.kok@versity.com>
aversecat
force-pushed
the
auke/hole_punch_ioctl_test
branch
from
03672d7 to
16b1710
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.