Observability config rewrite: remember projects, allow self-hosting, unify env var handling #775
+3,334
−922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3fb57e1.
Signed-off-by: Peter Wielander <[email protected]>
Signed-off-by: Peter Wielander <[email protected]>
🦋 Changeset detectedLatest commit: b2d538a The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
🧪 E2E Test Results
⏳ Tests are running... Started at: 2026-01-13T15:22:37Z ❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (16 failed)mongodb (1 failed):
starter (14 failed):
turso (1 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
|
Contributor
📊 Benchmark Results
⏳ Benchmarks are running... Started at: 2026-01-13T15:22:37Z 📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| return targetWorld; | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Environment variables from previous backend configurations persist on process.env when switching backends, causing potential configuration pollution
Signed-off-by: Peter Wielander <[email protected]>
Signed-off-by: Peter Wielander <[email protected]>
Signed-off-by: Peter Wielander <[email protected]>
| backend: 'WORKFLOW_TARGET_WORLD', | ||
| dataDir: 'WORKFLOW_LOCAL_DATA_DIR', | ||
| env: 'WORKFLOW_VERCEL_ENV', | ||
| authToken: 'WORKFLOW_VERCEL_AUTH_TOKEN', |
Contributor
There was a problem hiding this comment.
Sensitive authentication tokens (WORKFLOW_VERCEL_AUTH_TOKEN) are being stored in plaintext in localStorage via the project's envMap, creating a security vulnerability.
Signed-off-by: Peter Wielander <[email protected]>
Signed-off-by: Peter Wielander <[email protected]>
VaguelySerious
commented
Jan 13, 2026
| "lucide-react": "0.469.0", | ||
| "react": "19.1.0", | ||
| "react-dom": "19.1.0", | ||
| "shiki": "3.21.0", |
Member
Author
There was a problem hiding this comment.
This was added to fix a warning. shiki is installed via streamdown, but since the latest version, throws lots of warnings unless it's directly added as a dependency
Signed-off-by: Peter Wielander <[email protected]>
VaguelySerious
commented
Jan 13, 2026
| }, | ||
| "devDependencies": { | ||
| "@xyflow/react": "12.9.3", | ||
| "shiki": "3.21.0", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This superseeds #626 and #748, and reverts #747 in order to:
world-manifest.json. Updating the manifest will now directly update the UI support for worlds.The dream for this is that you can open your web app once, and easily switch between local/staging/prod envs, or different project/repos) without having to invoke the o11y separately every time.
Not in this PR, but now unblocked:
vc env pullif vercel credentials expiredTesting
I'm working on e2e tests for this, but in the meantime, I manually validated this PR extensively:
--localUIWORKFLOW_UI_SELF_HOSTING="1")wfis aliased to theworkflowlocal directory (contributor DevEx)What I didn't test:
Screenshots