Open
Conversation
Qix-
approved these changes
Nov 6, 2021
Contributor
Qix-
left a comment
There was a problem hiding this comment.
Man it is so incredibly weird how specific you can make Typescript. This is really cool, thanks.
I unfortunately do not have control over this repository anymore and can only approve and hope one of the Vercel staff see this and merge/publish a new minor version (please?).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is basically a small modification to the typings of this package, I basically added 2 new types to help TypeScript users define the arg specification more clearly.
Right now, you would need to define an interface prefixed with
--which is not common at all when writing interfaces:In this PR, this basically converts all the keys from the
Tgeneric from the default exports prefixed with dashes:Sorry for the bad writing, I'm not really good at explaining what I did within PRs (since I'm not usually a contributor on most repositories.)