Repository navigation
Stroke the checkbox mark through the vector core - #87
Merged
Merged
Conversation
- The check was two diagonal draw_line commands, and the line rasterizer's binary capsule test has no anti-aliasing, so the mark stair-stepped at every scale while the stroke icons around it rendered clean - One stroked polyline with round caps and a round join now rasterizes the same shape with real coverage; a test pins the anti-aliased property so the mark can never regress to hard edges
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…host - Path elements now live in builder-owned storage instead of threadlocal frame scratch, so commands from separately emitted trees can never alias each other's geometry; charts and the spinner adopt the same lifetime - The stroke cap rides the packet command, both wire encodings (v4), and the fingerprint, and the AppKit host applies it plus the reference renderer's round join when stroking paths
- Re-pin the components catalog signatures for the combined tree: the snap-default pins from main and the checkbox stroke pins from this branch both moved the same scenes
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The checkbox checkmark rendered chunky at small sizes — uneven stroke weight, stair-stepped edges, a mushy joint — while every built-in icon around it rendered clean.
Diagnosis
The mark was never an icon: it was two diagonal
draw_linecommands, and the line rasterizer's binary point-in-capsule test has no anti-aliasing at all. Every otherdraw_linein the product is axis-aligned (where the binary test is exact) — the checkbox was the only diagonal. All 50 built-in icons go through the vector core and were verified crisp via contact sheets; no icon change was needed.Fix
emitCheckboxWidgetemits the vee as one stroked polyline through the vector core — identical shape and vertices, width 2, round caps, a real round join at the vertex. The mark now rasterizes with the same anti-aliased coverage as the stroke icons, in both schemes, both theme packs, snapped and unsnapped.Verification
stroke_pathwith partial-coverage pixels inside the fill) plus the render signature