Repository navigation
Ship assets/ in the npm package - #75
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Stage the repo-root assets/ dir in copy-framework.js and list it in package.json files so generated apps can resolve assets/native-sdk.manifest (and the macOS icon/entitlements) from the installed package - Guard against regressions: check-framework-sync.js now fails when any dep.path reference in build/app.zig is missing from the staged mirror or the files array Fixes #72 Co-authored-by: lzitser23 <10744132+lzitser23@users.noreply.github.com>
ctate
force-pushed
the
fix/npm-package-assets
branch
from
July 9, 2026 12:23
1c93459 to
c6786ca
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #72
Bug
@native-sdk/cli0.4.0 ships withoutassets/, so every Windows build of a generated app fails at compile with'...\@native-sdk\cli\assets\native-sdk.manifest' file_hash FileNotFound—build/app.zigembeds the Windows manifest viadep.path("assets/native-sdk.manifest"), resolved from the installed package. macOS packaging assets (icon, entitlements) were exposed to the same failure class.Fix
copy-framework.js(prepack) now stages the repo-rootassets/dir into the package, andpackage.jsonlistsassetsinfilescheck-framework-sync.jsgains a regression guard: it extracts every package-relativedep.pathreference inbuild/app.zigand fails if any is missing from the staged mirror or not covered byfilesVerification
native init→zig build -Dtarget=x86_64-windowsnative init+native build --yesnow links the exefilesentry)npm run scripts:checkand repo gate green