Add a cabinets block tag, and a Mushroom Colonies item and block tag#1184
Open
thelegitdolt wants to merge 18 commits intovectorwing:dev/1.3from
Open
Add a cabinets block tag, and a Mushroom Colonies item and block tag#1184thelegitdolt wants to merge 18 commits intovectorwing:dev/1.3from
thelegitdolt wants to merge 18 commits intovectorwing:dev/1.3from
Conversation
Contributor
Author
|
Closes #902 |
thelegitdolt
changed the title
Contributor
Author
|
Since I've the fork and all, I've added a |
Owner
|
Hi! Sorry for the long delay. These tags seem reasonable. Could you point the PR towards the |
# Conflicts: # src/generated/resources/.cache/55b530523832603ee79ac7ef34cbb3a3a66f5973 # src/generated/resources/.cache/5b24237c90163b576498ce1130f3afc9fd6fdb33 # src/main/java/vectorwing/farmersdelight/data/ItemTags.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored the path of the current
ModTags#CABINETStoModTags#CABINET_ITEMSandModTags#WOODEN_CABINETStoModTags#WOODEN_CABINET_ITEMS, following the convention set by the wild crop tags. This might break the code of addons running datagen, but shouldn't cause a crash.