fix(cli): pass u64 limit/offset to regenerated client#2370
Merged
Conversation
The Rust client was regenerated with limit/offset typed as Option<u64> (unsigned, minimum 0 in the OpenAPI spec), but the api.rs wrappers still passed Option<i64>, breaking `cargo build` (and the test-rust-cli / test-doc-examples CI jobs). Cast the values to u64 at each call site (list_documents, list_memories, list_entities, get_graph, list_tags), matching the existing pattern already used for list_documents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cargo buildfor the Rust CLI fails onmain, breaking thetest-rust-cliandtest-doc-examples (cli)CI jobs:The generated
hindsight-clientwas regenerated withlimit/offsettyped asOption<u64>(the OpenAPI spec marks them as unsigned,minimum: 0), but the hand-writtenapi.rswrappers still passedOption<i64>.Fix
Cast
limit/offsettou64at each affected call site —list_documents,list_memories,list_entities,get_graph,list_tags— matching theas i64→as u64pattern already used forlist_documents. No wrapper signatures or callers change.Verification
cargo build— cleancargo test— 57 + 24 + 11 + 7 tests passcargo fmt --check— clean