ci(obs): enable consolidation dedup (0.97) in the observation benchmark#1998
Closed
nicoloboschi wants to merge 1 commit into
Closed
ci(obs): enable consolidation dedup (0.97) in the observation benchmark#1998nicoloboschi wants to merge 1 commit into
nicoloboschi wants to merge 1 commit into
Conversation
The obs benchmark exists to track consolidation's near-duplicate observation rate, but the job ran with dedup disabled (default threshold 1.0), so it measured the baseline rather than the shipped feature. Enable it at 0.97 in the job env. Safe here because the benchmark runs on embedded pg0 (Postgres); the merge path is Postgres-only, which is why the feature stays opt-in globally.
Collaborator
Author
|
Superseded by #2000, which enables dedup by default (so the benchmark picks it up automatically) and skips it on Oracle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The observation benchmark exists to track consolidation's near-duplicate rate, but the job ran with dedup disabled (default threshold
1.0), so it measured the baseline rather than the shipped create+update dedup feature (#1977).Enable it at
0.97in the obs job env so the benchmark + CPM dashboard track the feature going forward. Safe here because the benchmark runs on embedded pg0 (Postgres); the merge path is Postgres-only, which is why the feature stays opt-in / disabled by default rather than enabled globally (enabling it as the global default would break Oracle deployments).Dispatched a run on this branch to capture the dedup-on number.