Resolve the plugin root from sim-host.mjs, not by counting ../ from the bundle - #3
Open
dhiyaancnirmal wants to merge 1 commit into
Open
Conversation
…he bundle
defaultDeps() was handed new URL("../../", import.meta.url), which is the
plugin root when evaluated from src/sim/wire.ts but, from the bundled
dist/server.js, is the directory *containing* the install. For a git install
that is ~/.bb/plugins/cache/git/github.com/<owner>/bb-plugin-xcode/, which has
no node_modules, so require.resolve("serve-sim/middleware") fails and
`bb xcode sim doctor` reports serve-sim as not installed on a machine where
it is — with a STOP that blocks Live.
resolveSimHostPath already searches both layouts for sim-host.mjs, which sits
at the plugin root, so the root is simply its directory. Hoisted that lookup
above the preflight wiring and reused it.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a git install (
bb plugin install xcodefrom the marketplace),bb xcode sim doctorreports:even though
node_modules/serve-simand itsdist/native/serve-sim-native.nodeare present. Live is blocked by the STOP.Cause
src/sim/wire.tsbuilds the preflight deps withnew URL("../../", import.meta.url). Two abovesrc/sim/wire.tsis the plugin root, but two above the bundleddist/server.jsis the directory containing the install — for a git install,~/.bb/plugins/cache/git/github.com/<owner>/bb-plugin-xcode/, which has nonode_modules.require.resolve("serve-sim/middleware")from there fails, and the doctor concludes serve-sim is missing.Reproduced on bb 0.41.0 / macOS 26.5 / Xcode 27 beta with v0.2.2 from the marketplace, and the same line is on
main. Anode_modulessymlink one level up makes the doctor pass, which confirms the diagnosis.Fix
resolveSimHostPathalready searches both layouts forsim-host.mjs, which sits at the plugin root, so the root is itsdirname. Hoisted that lookup above the preflight wiring and reused it. No behaviour change when evaluated from source.npm run checkpasses.