feat(pi): vstack's Pi prompts arrive; the steward skill states its rules - #1603
Conversation
…m vstack Tracked under .pi/prompts as vstack tracked them; .pi is linked into worktrees child by child so the tracked prompts are never shadowed. Claude-Session: https://claude.ai/code/session_013EDioRsTBmsfaYeAah71hB
…ords Adds the convergence, scope, ratchet and no-admin rules; drops dated narration and a dotfiles home that does not exist. Claude-Session: https://claude.ai/code/session_013EDioRsTBmsfaYeAah71hB
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f2178f4ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
There was a problem hiding this comment.
Pull request overview
Adds tracked Pi maintenance prompts and tightens kendex issue-steward guidance.
Changes:
- Adds Pi update, npm deployment, and GitHub release workflows.
- Preserves tracked Pi prompts across worktrees.
- Simplifies and strengthens issue-steward rules.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
kendex.settings.toml |
Narrows Pi worktree symlinks. |
.pi/prompts/pi-update.md |
Adds Pi changelog audit workflow. |
.pi/prompts/npm-deploy.md |
Adds npm deployment workflow. |
.pi/prompts/gh-release.md |
Adds GitHub release workflow. |
.kendex-local/skills/kendex-issues/SKILL.md |
Condenses stewardship guidance. |
.gitignore |
Tracks Pi prompt files. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53f50a1220
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Suppressed comments (2)
Previously missed (2) — in code that hasn't changed since the last review.
.pi/prompts/npm-deploy.md:45
- A missing tag is marked for deployment even when
package.jsonalready equals the published npm version, but the only later tag path first bumps and publishes. That either attempts to republish an existing version or forces an unnecessary bump. Add a separate tag-repair path that verifies/locates the commit for the already-published version and creates the missing tag without publishing.
- npm version exists but matching git tag is missing,
.kendex-local/skills/kendex-issues/SKILL.md:86
- This directs the steward to merge when the only outstanding finding is missing test coverage, conflicting with the repository rule that every behavior change ships with a test. Remove test coverage from the automatically non-blocking list, or limit that exception to changes already verified as non-behavioral.
- **Review must converge** (orch SKILL.md): new defects at round 3 stop
per-comment patching. A round that is only scope, test-coverage, or
wording asks ends the review: reply, resolve, push nothing, merge through
the gate. Never `--admin`.
|
Record correction: the round-2 threads were resolved by a since-retired auto-resolver with "tracked" replies naming no issue, and four round-1 replies were mis-pasted from another PR. Audit outcome: the retag-after-merge and publish-from-synced-main findings were real and are fixed in #1610; the .env.npm ignore already landed in #1606; the remaining items are |
.pi/prompts/{gh-release,npm-deploy,pi-update}.mdported from vstack (tracked there, missing here), vstack→kendex renames,cli/paths → workspace..gitignoreun-ignores.pi/prompts;WORKTREE_SYMLINKSnames.pi/agents .pi/kendexinstead of.piso worktrees never shadow the tracked prompts (the vstack layout)..kendex-local/skills/kendex-issues/SKILL.md: 2,269 → 1,225 words; adds the scope / convergence / ratchet / no-admin rules; drops dated narration and a~/dotfileshome that does not exist.https://claude.ai/code/session_013EDioRsTBmsfaYeAah71hB