Improve JSON validation throughput by 11% - #122
Open
trevorprater wants to merge 1 commit into
Open
Conversation
trevorprater
marked this pull request as ready for review
July 3, 2026 16:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This replaces the validation string/key path with a single-pass scanner that validates control characters and escape sequences while scanning, instead of first locating strings and then doing follow-up scans/parsing.
It also avoids the
strconv/stringsimports on this path and keepsValidate/ValidateBytesbehavior unchanged.Why
The existing
Validatebenchmark fixtures spend a meaningful amount of time in string/key validation. The new scan keeps the same JSON validity checks but removes extra passes over already-scanned strings.This patch was found while experimenting with Sleepy - https://sleepy.run/mcp, then manually reviewed and validated locally before opening this PR.
Validation
Commands run on Apple M4 / darwin arm64:
go test -count=1 ./...Result:
I also ran an additional local differential test in a temporary worktree comparing both
ValidateandValidateBytesagainstencoding/json.Validover focused edge cases plus 20,000 deterministic randomized ASCII inputs. That check passed.Benchmark command:
benchstatsummary:Allocations stayed at 0 B/op and 0 allocs/op.