Skip to content

Conversation

@validbeck
Copy link
Collaborator

@validbeck validbeck commented Feb 3, 2026

Pull Request Description

What and why?

sc-14229

  • I removed the prompt for inserting a sample use case from the notebook generation template and any references to use cases from notebooks as this isn't necessarily a required field on registration depending on organization settings

  • I added some YAML uploads for templates referenced in notebooks that aren't by default part of organizations and instructions on how to ask customer admins to include these templates for use. For example:

    Screenshot 2026-02-03 at 2 37 05 PM

How to test

What needs special review?

Please make sure that the templates I added look accurate.

Dependencies, breaking changes, and deployment notes

n/a

Release notes

n/a

Checklist

  • What and why
  • Screenshots or videos (Frontend)
  • How to test
  • What needs special review
  • Dependencies, breaking changes, and deployment notes
  • Labels applied
  • PR linked to Shortcut
  • Unit tests added (Backend)
  • Tested locally
  • Documentation updated (if required)
  • Environment variable additions/changes documented (if required)

@validbeck validbeck self-assigned this Feb 3, 2026
@validbeck validbeck added the internal Not to be externalized in the release notes label Feb 3, 2026
Copy link
Contributor

@AnilSorathiya AnilSorathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @validbeck!

@juanmleng
Copy link
Contributor

I received an error about nbformat not being installed. The issue was that Makefile target make notebook was running python, not the Poetry environment (so nbformat wasn’t available).

Replace this:

@python notebooks/templates/e2e_template.py

by this:

poetry run python notebooks/templates/e2e_template.py

@juanmleng
Copy link
Contributor

Also I noticed that make notebook currently breaks if the notebook name contains spaces (e.g., test juan.ipynb). The editor CLI interprets the path as multiple args and ends up creating extra files like test and juan.ipynb in addition to the intended notebook. Perhaps, we should either normalize spaces to underscores or ensure the open/create step passes a properly quoted single filepath.

Copy link
Contributor

@juanmleng juanmleng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look awesome @validbeck ! I just a couple of minor comments.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

PR Summary

This PR introduces several improvements across the project. First, the Makefile now executes the notebook template generation script via Poetry instead of a direct Python call, standardizing the environment for running scripts.

New and updated YAML templates have been added for various documentation aspects such as Capital Markets, Code Explainer, and Gen AI RAG. These templates provide detailed sections covering metadata, model design, testing, data preparation, model evaluation, and monitoring/governance, which will help ensure consistency across documentation notebooks.

Multiple notebooks, across areas like credit risk, NLP/LLM, time series, and more, have been updated to remove redundant example texts for model registration. These changes streamline the instructions by removing hard-coded use case examples and improving template name consistency.

Additionally, the e2e_template.py script has been enhanced by adding filename normalization—replacing spaces with underscores and converting names to lowercase—which improves usability and consistency when creating new notebooks. A block of code handling the '{use-case}' replacement was also simplified and removed, reducing complexity without affecting the core functionality.

Test Suggestions

  • Run the Makefile target to confirm that 'poetry run python' executes the e2e_template.py as expected.
  • Test the notebook creation process by entering a name with spaces and uppercase letters, and verify that the resulting file name is normalized.
  • Load and preview the new YAML templates (for Capital Markets, Code Explainer, Gen AI RAG) in the documentation system to ensure proper formatting and valid YAML structure.
  • Open several updated notebooks to verify that the instructional text has been correctly updated (e.g., removal of outdated example use cases) and that all links work as expected.

@validbeck
Copy link
Collaborator Author

I received an error about nbformat not being installed. The issue was that Makefile target make notebook was running python, not the Poetry environment (so nbformat wasn’t available).

Replace this:

@python notebooks/templates/e2e_template.py

by this:

poetry run python notebooks/templates/e2e_template.py

Done in 37f071e!

Also I noticed that make notebook currently breaks if the notebook name contains spaces (e.g., test juan.ipynb). The editor CLI interprets the path as multiple args and ends up creating extra files like test and juan.ipynb in addition to the intended notebook. Perhaps, we should either normalize spaces to underscores or ensure the open/create step passes a properly quoted single filepath.

Spaces are turned into underscores in c265e6f. It now also normalises any capitals if entered, and removes any spaces from the end of the filename if entered as well.

@validbeck validbeck merged commit db4c995 into main Feb 6, 2026
7 checks passed
@validbeck validbeck deleted the beck/sc-14229/docs-notebooks-registration-updates branch February 6, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Not to be externalized in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants