Skip to content

[Legacy host seams] Owners: re-submit only still-needed minimal contracts #1

Closed as not planned

Description

@ShuhaoZhangTony

The two legacy repositories are immutable archives. Please do not reopen or merge their feature branches wholesale. If the capability is still needed against current main, submit a new, narrowly scoped PR to this fresh upstream-synchronized fork.

Candidates that still need an owner decision:

Before opening a PR:

  1. verify current upstream does not already implement the behavior;
  2. rebase/reimplement against current main rather than cherry-picking the old branch;
  3. preserve original authorship and link the legacy PR;
  4. add default-off equivalence and fail-closed compatibility tests;
  5. keep algorithms, policies, exporters, and device implementations in their extension repositories.

Already present in the current fork/upstream and therefore not requested again: EAGLE/EAGLE3/DSpark, QkNorm-RoPE, Mooncake connectors, current KV-offload/tiering infrastructure, and general hot-path/CI fixes.

Activity

  1. YWHUTER commented on Sep 1, 2026

    @YWHUTER

    @ShuhaoZhangTony owner decision completed for the @YWHUTER half of the pinned-output lifecycle item.

    I audited exact fresh main ed9f108ad80f4d8f058cf35541c785452c1c48ef before re-submitting: the native sampled-token D2H/event-wait/optional InputBatch second-consumer path remains, while vllm/v1/events.py or an equivalent neutral typed observer outlet is absent. No open PR in this fork or upstream implements this contract.

    A clean current-main reimplementation is now Draft PR #3, commit ede30a2c9a9e434d283139af9a191f323b48067a. It changes four Python files only: a default-off process-local typed outlet, seven generic async-output lifecycle payloads, guarded native call sites, and host tests. Exporter/ledger/cap/correlation/policy/device code remains out of Core. Legacy vllm-project#249/vllm-project#250/vllm-project#256/vllm-project#266 provenance and co-authors are preserved.

    Validation: targeted pytest 4 passed; Ruff/format, mypy 3.12, SPDX, forbidden-import, torch.cuda, typos, configuration, sign-off, and diff checks passed. No NPU run or performance claim. Parent Draft intellistream/vllm-host-control-batching#12 pins the new commit in b15eec5; independent Core API review is pending.

  2. xiehanlong834-gif commented on Sep 22, 2026

    @xiehanlong834-gif

    Owner decision for the @xiehanlong834-gif item (generic default-off KV lifecycle
    event seam from legacy vllm-project#266): already re-submitted and under review as #6.

    Fresh audit of current main (d680ae5a) before re-submitting:

    • vllm/v1/events.py does not exist on main; there is no request/session-level
      lifecycle outlet at the scheduler layer. vllm/distributed/kv_events.py
      (BlockStored/BlockRemoved) reports block residency, and the worker-level
      AsyncOutput* hooks cover output-token movement on the GPU path — neither
      reports "this request finished / was preempted / its KV was reclaimed", and
      neither carries a request identity that survives preemption.
    • No open PR in this fork implements that seam. feat(observability): expose default-off request lifecycle events #6 is the narrowly scoped
      re-submission of [BugFix] Fix a bug in counting running sequences vllm-project/vllm#266: vllm/v1/events.py (new) plus emit points in
      Scheduler._free_request, Scheduler._preempt_request and the block-release
      paths, with tests/v1/core/test_request_lifecycle_events.py.

    Scope is kept to what this issue asks for:

    • Generic and typed. RequestFinished, RequestPreempted,
      RequestKvReclaimed carry request metrics only — no CLM/DLA/experiment
      semantics in core.
    • Default off. EventBus.enabled is False until a sink registers; every
      emit site is guarded, so the default path allocates nothing.
    • Exporter/policy code stays out of core, in
      vllm-hust-kv-transfer-observability and vllm-hust-clm-lifecycle, as the
      issue instructs.
    • Rebased onto current main rather than cherry-picking the old branch, with
      original authorship and the legacy PR linked in the commit/PR description.

    No new PR is needed for this item; #6 replaces vllm-project#266. Marking the checkbox above
    can follow the review outcome.

    One environment note for whoever picks up the remaining items on this list: the
    vllm-ascend-hust currently installed on the shared node (0.19.1) no longer
    imports against current main — vllm_ascend/ops/fused_moe/fused_moe.py:32
    does from vllm.model_executor.layers.fused_moe.layer import FusedMoE, which
    main no longer exports. Any test that constructs a real Scheduler fails there
    for that reason alone (reproduced with the unmodified upstream
    tests/v1/core/test_scheduler.py::test_finish_request). Syncing
    vllm-ascend-hust to main unblocks scheduler-level verification for everyone.

  3. ShuhaoZhangTony commented on Nov 8, 2026

    @ShuhaoZhangTony
    MemberAuthor

    2026-11-08 maintainer closure: this migration-era umbrella is superseded by capability-owned repositories and current-main PRs. Prefix routing, lifecycle/KV observability, Unified Communication, scheduling policies, and other seams now have their own implementation/evidence ledgers; several accepted minimal Host contracts are already in main. Unimplemented legacy branches are not approved by this closure and must never be merged wholesale. Any remaining need must be filed as a narrow current-main issue from the owning MOD with tests, default-off semantics, and rollback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions