fix: Enforce non-zero positive sandbox timeouts to prevent indefinite hangs (#1808)#2050
Open
Rakshak05 wants to merge 2 commits into
Open
fix: Enforce non-zero positive sandbox timeouts to prevent indefinite hangs (#1808)#2050Rakshak05 wants to merge 2 commits into
Rakshak05 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a vulnerability/bug where a falsy sandbox
timeout_secondsvalue (0, negative, orNone) allowed subprocess execution and reader tasks to run indefinitely without a wall-clock limit. If a scanner hung, the process would run forever.To resolve this:
@field_validatortoSandboxConfiginmodels.pythat raises aValidationError/ValueErrorand logs a warning iftimeout_secondsis<= 0orNone.@field_validatortoSettingsinconfig.pythat checks bothsandbox_timeoutandparser_sandbox_timeout_seconds, raising aValidationError/ValueErrorand logging a warning if they are<= 0orNone.Related Issues
Closes #1808
Type of Change
How Has This Been Tested?
Ran the updated unit test suite targeting config settings and sandbox configurations:
Results: All 78 tests passed.
Checklist