Skip to content

Fixed length of abbreviated loc for a clone #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulKlint merged 2 commits into from
Dec 6, 2025
Merged

Fixed length of abbreviated loc for a clone #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9134eba
Fixed length of abbreviated loc for a clone
PaulKlint Dec 5, 2025
ecfc767
Restrict clone location to single line
PaulKlint Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/analysis/typepal/Collector.rsc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1011,6 +1011,17 @@ Collector newCollector(str modelName, map[str,Tree] namedTrees, TypePalConfig co
paths += tm.paths;
}

loc limitLocToFirstLine(loc l){
try {
str txt = readFile(l);
int k = findFirst(txt, "\n");
if(k >= 0){
return l[length=k][end=<l.begin.line,k>];
}
} catch _:;
return l;
}

map[loc,loc] buildLogical2physical(Defines defines){
map[loc,loc] my_logical2physical = logical2physical;
map[loc,loc] my_physical2logical = ();
Expand All @@ -1030,7 +1041,7 @@ Collector newCollector(str modelName, map[str,Tree] namedTrees, TypePalConfig co
info("Clone of `<def.id>`", def.defined)
];
// restrict clone location to first line for readability
messages += error("Remove code clone for <prettyRole(def.idRole)> `<def.id>`", def.defined[end=<def.defined.begin.line+1,0>], causes=causes);
messages += error("Remove code clone for <prettyRole(def.idRole)> `<def.id>`", limitLocToFirstLine(def.defined), causes=causes);
}
}
my_logical2physical[logicalLoc] = def.defined;
Expand Down