feat(renderer): relaxed-TLS fallback for cert-broken origins#192
Merged
Conversation
A fetch that fails TLS certificate verification now retries ONCE with verification disabled (gated by CRW_HTTP_TLS_RELAXED_FALLBACK, cert-errors only, logged as tls_unverified). Recovers small / long-tail sites whose certs are misconfigured or expired but whose content is perfectly fetchable; every other failure mode keeps strict verification. SSRF protection is unaffected (it runs on the resolved URL, not the TLS layer). Measured: 427 previously-502 customer URLs -> 186 recovered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry a TLS-cert-verification failure ONCE with verification disabled (gated by CRW_HTTP_TLS_RELAXED_FALLBACK, cert-errors only, tls_unverified). Recovers long-tail sites with broken/expired certs. SSRF unaffected. Measured: 427 prev-502 customer URLs -> 186 recovered.