Skip to content

ICU-20656 Add icu4j data tracing#3795

Merged
sffc merged 1 commit intounicode-org:mainfrom
eranl:dataTracing
Feb 4, 2026
Merged

ICU-20656 Add icu4j data tracing#3795
sffc merged 1 commit intounicode-org:mainfrom
eranl:dataTracing

Conversation

@eranl
Copy link
Copy Markdown
Contributor

@eranl eranl commented Dec 11, 2025

Add a dataTracing debug flag, which enables logging of the name of every data or resource file accessed at runtime.

Checklist

  • [v] Required: Issue filed: ICU-20656
  • [v] Required: The PR title must be prefixed with a JIRA Issue number.
  • [v] Required: Each commit message must be prefixed with a JIRA Issue number.
  • [v] Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • [v] Approver: Feel free to merge on my behalf

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 11, 2025

CLA assistant check
All committers have signed the CLA.

@jira-pull-request-webhook
Copy link
Copy Markdown

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link
Copy Markdown

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu
Copy link
Copy Markdown
Member

Could you please restore and fill in the pull request template?

@markusicu
Copy link
Copy Markdown
Member

Is the C++ data tracing documented in the User Guide? If so, then we should document the Java tracing there, too.

@eranl
Copy link
Copy Markdown
Contributor Author

eranl commented Dec 18, 2025

Is the C++ data tracing documented in the User Guide?

Yes, here.

If so, then we should document the Java tracing there, too.

Should I do that? How?

@eranl
Copy link
Copy Markdown
Contributor Author

eranl commented Dec 18, 2025

Could you please restore and fill in the pull request template?

Done.

Copy link
Copy Markdown
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second Markus's comments, but the actual code changes look fine to me.

@sffc
Copy link
Copy Markdown
Member

sffc commented Feb 4, 2026

Refreshing CI

@sffc sffc closed this Feb 4, 2026
@sffc sffc reopened this Feb 4, 2026
@jira-pull-request-webhook
Copy link
Copy Markdown

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@eranl
Copy link
Copy Markdown
Contributor Author

eranl commented Feb 4, 2026

Commits squashed.

@sffc sffc merged commit 3a5666b into unicode-org:main Feb 4, 2026
17 checks passed
@eranl
Copy link
Copy Markdown
Contributor Author

eranl commented Feb 6, 2026

Is the C++ data tracing documented in the User Guide?

Yes, here.

If so, then we should document the Java tracing there, too.

Should I do that? How?

What's the process for this?

@sffc
Copy link
Copy Markdown
Member

sffc commented Feb 6, 2026

The file is in the repo; you can edit it in a new PR

https://github.com/unicode-org/icu/blob/main/docs/userguide/icu_data/tracing.md

@eranl
Copy link
Copy Markdown
Contributor Author

eranl commented Feb 8, 2026

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants