Repository navigation
refactor(plan): share the renamed-plan probe order - #472
Merged
Merged
Conversation
the function moved from server.go to plan.go in 307f4f4, its tests stayed behind in server_test.go. Moved unchanged, one test file per source file.
the dashboard loader and the processor plan locator each spelled out the same probe order by hand, and the copies drifted after #342: the web side got only the completed/ probe until #470. plan.CandidatePaths now returns the order once (original, in-place alternate date, completed/ with each basename) and both callers walk it. Behavior is unchanged, including surfacing non-not-found errors in the web loader. resolvePlanMoveTargets in pkg/git keeps its own probes since it returns a source/destination pair against a caller-supplied completed dir. CLAUDE.md now names the web loader and the shared helper in the rename tolerance bullet.
the comment named resolvePlanFilePath in pkg/processor/prompts.go, which became planLocator.Path in #364 and now takes its order from plan.CandidatePaths.
Deploying ralphex with
|
| Latest commit: |
5141804
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ac30eb1c.ralphex.pages.dev |
| Branch Preview URL: | https://plan-rename-probe-order.ralphex.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to #470. The renamed-plan probe order (original path, same-dir alternate date name,
completed/with each name) was written out by hand inpkg/web/plan.goandpkg/processor/plan_locator.go, and the two copies drifted once: #342 gave the in-place probe only to the processor, #470 fixed the web side.plan.CandidatePathsinpkg/plan/altdate.goreturns that order once; the web loader andplanLocator.Pathboth walk it. Behavior is unchanged, including the web loader stopping on any error other than not-found.resolvePlanMoveTargetsinpkg/gitkeeps its own probes, since it returns a source/destination pair against a caller-suppliedcompleted/dir. Its stale doc comment now points at the new helper.TestLoadPlanWithFallbackmoves unchanged fromserver_test.goto a newplan_test.go, next to the function it tests.