Repository navigation
fix(executor): point claude error-pattern failures at /status, not /usage - #469
Merged
Merged
Conversation
…sage Claude checks limit patterns before error patterns, so a PatternMatchError from claude is always a non-limit failure: an expired OAuth token (API Error: 401), "Not logged in", another 4xx or a 500. The "run 'claude /usage'" hint sent those users to usage limits, which is the wrong place for an auth error. Error-pattern matches now suggest `claude /status`, which shows the login and account state, matching the `codex /status` hint codex already prints. Limit-pattern matches keep `claude /usage`. Related to #235
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the Claude executor error-hint update.
No open issues 🎉
What changed in this PR
Updates Claude executor error hints to direct authentication and other error-pattern failures to account status rather than usage information.
Changes:
- Suggests
claude /statusfor error-pattern matches while preservingclaude /usagefor limit-pattern matches. - Updates test expectations and adds coverage for an expired OAuth token returning HTTP 401.
| File | Description |
|---|---|
pkg/executor/executor.go |
Changes the error-pattern help command and updates its field-comment example. |
pkg/executor/executor_test.go |
Updates help-command assertions and adds an expired-token regression case. |
Review effort: Balanced
Deploying ralphex with
|
| Latest commit: |
25e8ab4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9bd7bb6c.ralphex.pages.dev |
| Branch Preview URL: | https://claude-error-hint-status.ralphex.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
claude checks limit patterns before error patterns, so an error-pattern match from claude is always a non-limit failure: an expired OAuth token (
API Error: 401), "Not logged in", another 4xx or a 500. Therun 'claude /usage' for more informationhint pointed those at usage limits. In the linked discussion the reporter's first reply to a 401 was "It's not a usage issue for sure".error-pattern matches now suggest
claude /status, which shows the login and account state, same as thecodex /statushint codex already prints. Limit-pattern matches keepclaude /usage. A new test case covers the expired-token 401.Related to #235