Skip to content

Conversation

@kuitos
Copy link
Member

@kuitos kuitos commented Jul 16, 2025

This PR addresses various code quality, stability, and user experience issues in the create-qiankun CLI tool.

Key improvements include:

  • Enhanced Error Handling & Input Validation: Added robust try-catch blocks and input validation (e.g., project name, port numbers) across core functions.
  • Improved Port Generation: Rewrote the port generation algorithm to prevent conflicts, exclude common/system ports, and ensure availability.
  • Refactored Logic: Optimized template rendering, script injection, and Qiankun configuration injection for better robustness and clarity.
  • Utility Function Enhancements: Improved Git initialization (checks for existing repo), directory traversal (skips hidden files), and path normalization.
  • Code Redundancy: Removed duplicate scripts definitions in the React18 main application template.
  • User Experience: Improved error messages and logging for clearer feedback.
  • close https://github.com/umijs/qiankun/ISSUE_URL

@vercel
Copy link

vercel bot commented Jul 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
qiankun ❌ Failed (Inspect) Jul 16, 2025 9:08am

@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2025

⚠️ No Changeset found

Latest commit: d3cf181

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

- Add comprehensive English README.md with detailed usage guide
- Add Chinese README-zh.md with localized content
- Remove old Readme.md file
- Document all recent improvements and fixes
- Include project structure, development guide, and troubleshooting
- Add port management and input validation documentation
- Set README.md as default English version with simplified language navigation
- Update README-zh.md to use consistent language navigation format
- Keep English documentation as primary with clear link to Chinese version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants