fix: Missing dependency when provisioning service with request scaling (off-ticket)

[JohnStainsby]

• Add dependency on dummy listener rule invocation when looking up load balancer for request scaling

This fixes an error in service Terraform when provisioning a service with request based autoscaling. Terraform tries to find the load balancer associated with the target group but this link isn't in place until the dummy listener rule lambda executes.

The order of execution should be:

Create target group -> Run lambda to associate with ALB -> Get ALB info -> Setup request autoscaling

Signed-off-by: DBT pre-commit check

---

Checklist:

Title:

• Conforms to our pull request title guidance. E.g. feat: Add new feature (DBTP-1234) or chore: Correct typo (off-ticket)

Description:

• Link to ticket included (unless it's a quick out of ticket thing)
• Includes tests (or an explanation for why it doesn't)
• If the work includes user interface changes, before and after screenshots included in description
• Includes any applicable changes to the documentation in this code base
• Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

• Run the end to end tests for this branch and confirm that they are passing

Reviewer Checklist

• I have reviewed the PR and ensured no secret values are present

[adrianclay]

Could lines 369 and 370 be moved here instead?

aws_appautoscaling_policy.requests_autoscaling_policy depends on aws_lb.load_balancer, which if we now have the depends_on within the aws_alb block here removes the need for the depends_on within the aws_appautoscaling_policy.