Skip to content

test: expand markdown and table logic coverage#4870

Merged
zbeyens merged 1 commit intomainfrom
codex/core-use-slate-props-tests
Mar 16, 2026
Merged

test: expand markdown and table logic coverage#4870
zbeyens merged 1 commit intomainfrom
codex/core-use-slate-props-tests

Conversation

@zbeyens
Copy link
Member

@zbeyens zbeyens commented Mar 15, 2026

Summary

  • deepen non-React markdown logic coverage and fix incomplete MDX fallback when a parsed prefix ends in a void block
  • add focused table lib coverage for merge, split, expanded row/column deletion, sizing, and selection movement
  • include the current checkout's existing task-skill docs and useSlateProps test updates as-is

Testing

  • bun test packages/markdown/src
  • bun run test:slowest -- --top 15 packages/markdown/src
  • bun test packages/table/src/lib/merge/tableMergeBehavior.spec.tsx packages/table/src/lib/transforms/tableSelectionAndSizing.spec.tsx
  • bun test packages/table/src/lib
  • bun run test:slowest -- --top 15 packages/table/src/lib
  • pnpm install
  • pnpm turbo typecheck --filter=./packages/table
  • pnpm lint:fix

Notes

  • pnpm turbo build --filter=./packages/markdown and pnpm turbo build --filter=./packages/table are blocked by an external rolldown / Node 20.12.1 node:util.styleText failure in transitive build work, not by the package changes here.
  • bun check was not run before opening this PR because it was explicitly skipped.

Post-Deploy Monitoring & Validation

No additional operational monitoring required. This PR is test/doc heavy, and the only runtime change is a narrow markdown fallback fix covered by package tests.

@zbeyens zbeyens requested a review from a team March 15, 2026 21:10
@codesandbox
Copy link

codesandbox bot commented Mar 15, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@vercel
Copy link

vercel bot commented Mar 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
plate Ready Ready Preview, Comment Mar 15, 2026 9:14pm

Request Review

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Mar 15, 2026
@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2026

🦋 Changeset detected

Latest commit: 327adce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@platejs/markdown Patch
@platejs/ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added plugin:markdown Markdown deserializer plugin:table Tables test labels Mar 15, 2026
@zbeyens zbeyens changed the title test test: expand markdown and table logic coverage Mar 15, 2026
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 16, 2026
@zbeyens zbeyens merged commit ebe2e59 into main Mar 16, 2026
3 checks passed
@zbeyens zbeyens deleted the codex/core-use-slate-props-tests branch March 16, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer plugin:markdown Markdown deserializer plugin:table Tables size:XXL This PR changes 1000+ lines, ignoring generated files. test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants