Repository navigation
lib/uloop: pass eof and error to cb - #350
Merged
Merged
Conversation
Collaborator
|
LGTM, please add your signoff here as well. |
Signed-off-by: Leon M. Busch-George <leon@georgemail.eu>
yogo1212
force-pushed
the
uloop_cb_args
branch
from
November 27, 2025 17:44
db1fbd4 to
1affe48
Compare
Collaborator
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch, the callback is called only with
events == 0when the fd is closed.Adding the
eofanderrorparameters allows making a more informed decision about what to do with the handle.Existing programs should continue to function without any changes since excess arguments are dropped by
uc_vm_call_function.