Repository navigation
uloop: allow reusing the existing environment for a new process - #344
Merged
Merged
Conversation
When passing null as environment argument to uloop.process(), reuse existing environ. This makes it possible to avoid having to duplicate and convert it by passing the output of getenv(). Signed-off-by: Felix Fietkau <nbd@nbd.name>
Collaborator
|
Explicit null leading to inheritance seems counterintuitive on a first glance. My gut feeling would be null == nothing == empty environment. What about |
Collaborator
|
I did revisit it again and came to the conclusion that inherit on Sorry for the long delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passing null as environment argument to uloop.process(), reuse existing environ.
This makes it possible to avoid having to duplicate and convert it by passing the output of getenv().