core: improve ergonomics of the attribute API (Scala 3)#1191
Open
iRevive wants to merge 1 commit intotypelevel:mainfrom
Open
core: improve ergonomics of the attribute API (Scala 3)#1191iRevive wants to merge 1 commit intotypelevel:mainfrom
iRevive wants to merge 1 commit intotypelevel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
The new API will be available only for Scala 3.
These changes should address the existing 'verbosity' problem:
The new varargs API allows using
Attribute,Option[Attribute], andIterable[Attribute]in the same call.Let's imagine we have the following setup:
Currently, to create a span or record a metric, we need to do the following:
With the new API, these attributes can be used directly: