fix: Adding mock server and test case to verify http timeout#649
Draft
fix: Adding mock server and test case to verify http timeout#649
Conversation
…out functionality
| @@ -0,0 +1,81 @@ | |||
| require 'minitest/autorun' | |||
Contributor
There was a problem hiding this comment.
Any reason why there's a separate testcases folder? Don't think these tests would be picked up with the automated test runs, the test command follows a pattern that picks up the files in spec folder with filename ending with _spec.rb. Anything else, doesn't run.
shrutiburman
requested changes
May 8, 2023
Contributor
shrutiburman
left a comment
There was a problem hiding this comment.
The comment posted earlier needs to be resolved. If we are not prioritising this right now, lets turn it into a draft PR, since some work is done on this.
Contributor
Author
We are not prioritising this right now, converted this to a draft PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
DII-933 Adding test case to test http global timeout
A short description of what this PR does.
Adding test case to test http global timeout
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.