Fix bad image URL in server browsing dialog box#690
Open
intersel wants to merge 1 commit into
Open
Conversation
As path directory may be symbolic link in $_SERVER['DOCUMENT_ROOT'], to remove it from $$document_root we need to use realpath to solve correctly the path
intersel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As path directory may be a symbolic link in $_SERVER['DOCUMENT_ROOT'], the URL of pictures in the dialog box browsing images on the server may be wrongly solved....
To get the correct relative path from $document_root, we need to use php realpath function to remove it and solve correctly the relative path