Skip to content

fix(cache,server): don't log http timeouts #9040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cschmatzler merged 1 commit into from
Jan 5, 2026
Merged

fix(cache,server): don't log http timeouts #9040

cschmatzler merged 1 commit into from
Jan 5, 2026

Conversation

@cschmatzler
Copy link
Member

@cschmatzler cschmatzler commented Dec 31, 2025 •
edited
Loading

This should block exceptions with Body read timeout from reaching AppSignal. These are expected from clients cancelling uploads.

@cschmatzler cschmatzler marked this pull request as ready for review January 1, 2026 00:07
@dosubot dosubot bot added the size:M For issues that take a handful of hours to implement label Jan 1, 2026
@dosubot
Copy link

dosubot bot commented Jan 1, 2026 •
edited
Loading

Related Documentation

Checked 1 published document(s) in 0 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@dosubot dosubot bot added the type:bug Something isn't working label Jan 1, 2026
fortmarek
fortmarek approved these changes Jan 2, 2026
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 2, 2026
@dosubot dosubot bot added size:L For issues that take up to a day to implement and removed size:M For issues that take a handful of hours to implement labels Jan 5, 2026
@cschmatzler cschmatzler force-pushed the push-kwluuvvoxtry branch 3 times, most recently from ccbe33a to 0fc0b6f Compare January 5, 2026 08:08
@tuist
Copy link

tuist bot commented Jan 5, 2026 •
edited
Loading

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Cache hit rate Tests Skipped Ran Commit
TuistKitAcceptanceTests ❌ 0 % 46 0 46 c98895f71

Builds 🔨

Scheme Status Duration Commit
TuistKitAcceptanceTests ✅ 41.2s c98895f71

@cschmatzler cschmatzler requested a review from fortmarek January 5, 2026 08:16
@cschmatzler cschmatzler merged commit 5b828a8 into main Jan 5, 2026
19 checks passed
@cschmatzler cschmatzler deleted the push-kwluuvvoxtry branch January 5, 2026 08:34
pepicrft pushed a commit that referenced this pull request Jan 9, 2026
@cschmatzler @pepicrft
fix(cache,server): don't log http timeouts (#9040)
73d400e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fortmarek fortmarek fortmarek approved these changes

Assignees

No one assigned

Labels

lgtm This PR has been approved by a maintainer size:L For issues that take up to a day to implement type:bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cschmatzler @fortmarek