Conversation
processClass only set classObj.name when nodes[1] AND nodes[2] were both string atoms, treating nodes[2] as a required "description". But a class with no description -- nodes[2] is the first nested list (e.g. `(clearance_class ...)`), not a string -- is valid DSN, see the `default` class in tests/assets/testkicadproject/freeroutingTraceAdded.dsn. The class's name was silently dropped whenever it had no description, even though name and description are independent fields. Added tests/repros/repro22-class-name-without-description.test.ts. Confirmed it fails without the fix (name undefined instead of "default") and passes with it. Full suite: 56 pass / 1 pre-existing skip / 0 fail. /claim tscircuit#54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
`processClass` only set `classObj.name` when nodes[1] and nodes[2] were both string atoms, treating nodes[2] as a required "description". But a class with no description — nodes[2] is the first nested list (e.g. `(clearance_class ...)`), not a string — is valid DSN. See the `default` class in `tests/assets/testkicadproject/freeroutingTraceAdded.dsn`:
```
(class default
(clearance_class default)
(via_rule default)
(rule (width 200.0))
)
```
The class's name was silently dropped whenever it had no description, even though name and description are independent fields.
Fix
Set `name` and `description` independently instead of gating both on the same combined check.
Verification
Added `tests/repros/repro22-class-name-without-description.test.ts`. Confirmed it fails without the fix (name `undefined` instead of `"default"`) and passes with it.
Full suite: 56 pass / 1 pre-existing skip / 0 fail.
/claim #54