Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
TP1) when connecting traces without changing global selector semantics.selectOne/caching broadly and was fragile; a minimal, localized approach is safer.Description
Trace__findConnectedPortsthat, when a trace endpoint selector fails to resolve as a port and does not explicitly contain a port token, resolves the selector as a component and returns its solePortif the component has exactly one port.resolveImplicitSinglePort(selector)and is only used whenselectOne(selector, { type: 'port' })returnsnull.single-pin-component-implies-pin1.test.tsx(accept single-pin implicit selector) andmulti-pin-component-no-implied-pin1-trace-error.test.tsx(ensure multi-pin components do not implypin1).Testing
BUN_UPDATE_SNAPSHOTS=1 bun test tests/components/base-components/single-pin-component-implies-pin1.test.tsxand the test passed with snapshots created.bun test tests/components/base-components/multi-pin-component-no-implied-pin1-trace-error.test.tsx tests/components/base-components/trace-port-selector-errors.test.tsx tests/components/base-components/shorthand-selector.test.tsxand all tests passed.bunx tsc --noEmitfor type-checking andbun run format; both completed successfully.Codex Task