Enable TP1-style single-pin trace connections and eliminate order-dependent selectOne cache collisions#2009
Closed
AnasSarkiz wants to merge 3 commits intotscircuit:mainfrom
Closed
Enable TP1-style single-pin trace connections and eliminate order-dependent selectOne cache collisions#2009AnasSarkiz wants to merge 3 commits intotscircuit:mainfrom
AnasSarkiz wants to merge 3 commits intotscircuit:mainfrom
Conversation
…endent selectOne cache collisions
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
reviewed
Mar 4, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
This is crazy, anyway to make this more conventional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves trace selector reliability and usability by allowing single-pin components to be connected by component name (for example,
TP1), while preserving strict behavior for multi-pin parts.Impact
pin1in trace selectors, reducing selector verbosity and avoiding unnecessary connection errors.selectOnecaching is now type-scoped, removing order-dependent lookup behavior when typed and untyped queries are mixed.Coverage
TP1 -> U1.pin2implicit single-pin behavior.pin1for multi-pin components (R1).