Implement constraint between groups with centerX/centerY#2006
Closed
legendary658 wants to merge 1 commit intotscircuit:mainfrom
Closed
Implement constraint between groups with centerX/centerY#2006legendary658 wants to merge 1 commit intotscircuit:mainfrom
legendary658 wants to merge 1 commit intotscircuit:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3 tasks
Add support for <constraint> to work between groups, not just individual components. Extends constraint props with centerX/centerY for absolute positioning of constraint clusters.
legendary658
force-pushed
the
feat-constraint-groups
branch
from
972d53f to
36bbee0
Compare
Contributor
|
this actually isn't too bad of a PR, but you're not allowed to extend props like that, you have to edit the tscircuit/props repo fwiw we do not do bounties anymore, i've closed the original issue (it's still a valid issue but the bounty spam is/was too high) we do automatic sponsorships for contributors, see contributions.tscircuit.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #1391
Summary
centerX/centerYprops to<constraint />for absolute positioning of constraint clustersleft=".group1" right=".group2")source_group_idin addition topcb_component_idapplyPackOutputto handle group members within clustersUsage
This sets a 20mm center-to-center distance between group1 and group2, centered at x=0.
Test plan
component-constraints01) still passesxDist+centerXxDist+centerXtsc --noEmit)