Skip to content

chore: drop redundant .rhiza/.env and .rhiza/.gitignore - #528

Merged
tschm merged 2 commits into
mainfrom
chore/drop-rhiza-env-gitignore
Aug 19, 2026
Merged

chore: drop redundant .rhiza/.env and .rhiza/.gitignore#528
tschm merged 2 commits into
mainfrom
chore/drop-rhiza-env-gitignore

Conversation

@tschm

@tschm tschm commented Aug 19, 2026

Copy link
Copy Markdown
Owner

Removes two .rhiza/ files that no longer carry any configuration.

.rhiza/.env

Its only two assignments were:

MARIMO_FOLDER=docs/notebooks
SOURCE_FOLDER=src

Both are byte-identical to the ?= defaults in .rhiza/rhiza.mk:103-106. Since rhiza.mk:94 pulls the file in with -include, its absence is a no-op — the defaults apply unchanged.

Dropping it also restores the env-overridability the file's own header describes: a makefile assignment beats an exported environment variable in GNU make's precedence order, so pinning these two here made them command-line-only overrides for no benefit.

.rhiza/.gitignore

Contained a single rule, !.env, which existed solely to un-ignore .rhiza/.env against the root .gitignore:11. With the .env gone it has nothing to un-ignore.

Verification

make doctor runs clean after the removal; pre-commit passes.

Note

Both files are template-owned and synced by rhiza. Unless upstream drops them too, a future /rhiza:update may restore them.

🤖 Generated with Claude Code

.rhiza/.env only set SOURCE_FOLDER=src and MARIMO_FOLDER=docs/notebooks,
which are byte-identical to the ?= defaults in .rhiza/rhiza.mk. rhiza.mk
-includes the file, so its absence is a no-op.

.rhiza/.gitignore contained only `!.env`, which existed solely to
un-ignore .rhiza/.env against the root .gitignore. With the .env gone it
has no purpose.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 19, 2026 03:42
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@tschm, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c5aaa52-8588-4555-9914-541834b9d9f9

📥 Commits

Reviewing files that changed from the base of the PR and between c37efa4 and 61795e8.

📒 Files selected for processing (2)
  • .rhiza/.env
  • .rhiza/.gitignore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes two redundant .rhiza/ files whose contents are already covered by defaults in .rhiza/rhiza.mk, simplifying the repo’s Rhiza template footprint without changing behavior.

Changes:

  • Delete .rhiza/.env, relying on .rhiza/rhiza.mk defaults for SOURCE_FOLDER and MARIMO_FOLDER via ?= assignments and -include.
  • Delete .rhiza/.gitignore, which previously existed only to un-ignore the now-removed .rhiza/.env.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.rhiza/.env Removed redundant env overrides now covered by rhiza.mk defaults.
.rhiza/.gitignore Removed un-ignore rule that only supported tracking .rhiza/.env.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@tschm
tschm merged commit dfb8140 into main Aug 19, 2026
46 checks passed
@tschm
tschm deleted the chore/drop-rhiza-env-gitignore branch August 19, 2026 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants