chore: drop redundant .rhiza/.env and .rhiza/.gitignore - #528
Conversation
.rhiza/.env only set SOURCE_FOLDER=src and MARIMO_FOLDER=docs/notebooks, which are byte-identical to the ?= defaults in .rhiza/rhiza.mk. rhiza.mk -includes the file, so its absence is a no-op. .rhiza/.gitignore contained only `!.env`, which existed solely to un-ignore .rhiza/.env against the root .gitignore. With the .env gone it has no purpose. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 41 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR removes two redundant .rhiza/ files whose contents are already covered by defaults in .rhiza/rhiza.mk, simplifying the repo’s Rhiza template footprint without changing behavior.
Changes:
- Delete
.rhiza/.env, relying on.rhiza/rhiza.mkdefaults forSOURCE_FOLDERandMARIMO_FOLDERvia?=assignments and-include. - Delete
.rhiza/.gitignore, which previously existed only to un-ignore the now-removed.rhiza/.env.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.rhiza/.env |
Removed redundant env overrides now covered by rhiza.mk defaults. |
.rhiza/.gitignore |
Removed un-ignore rule that only supported tracking .rhiza/.env. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Removes two
.rhiza/files that no longer carry any configuration..rhiza/.envIts only two assignments were:
Both are byte-identical to the
?=defaults in.rhiza/rhiza.mk:103-106. Sincerhiza.mk:94pulls the file in with-include, its absence is a no-op — the defaults apply unchanged.Dropping it also restores the env-overridability the file's own header describes: a makefile assignment beats an exported environment variable in GNU make's precedence order, so pinning these two here made them command-line-only overrides for no benefit.
.rhiza/.gitignoreContained a single rule,
!.env, which existed solely to un-ignore.rhiza/.envagainst the root.gitignore:11. With the.envgone it has nothing to un-ignore.Verification
make doctorruns clean after the removal; pre-commit passes.Note
Both files are template-owned and synced by rhiza. Unless upstream drops them too, a future
/rhiza:updatemay restore them.🤖 Generated with Claude Code