Fix/150 collection permalinks#170
Open
RalphBln wants to merge 3 commits into
Open
Conversation
nichtich
requested changes
Jun 11, 2026
| return addCollectionIRI(filterOutByTerminologies(terminologiesCollection.getTerminologies(), data), terminologiesCollection); | ||
| } | ||
|
|
||
| protected AggregatedApiResponse addCollectionIRI(AggregatedApiResponse response, TerminologyCollection terminologyCollection) { |
Contributor
There was a problem hiding this comment.
The field should not be http://base4nfdi.de/ts4nfdi/schema/collectionIRI but iri. The iri field should then be mapped to the subject URI in JSON-LD context document:
"@context": {
"iri": "@id"Existing field versionIRI could better be merged into identifier (unless there is a clear definition of its semantic difference, I don't see one).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #150.
It adds the possibility to use the collection permalink as a query parameter (e.g. https://terminology.services.base4nfdi.de/api-gateway/artefacts?collectionId=https://w3id.org/ts4nfdi/collection/dc45621d-7e40-47ce-9616-4133f0b54edf) and adds the collection permalink to the search result (if the collection uuid or permalink IRI has been used in the query).
The PR introduces the property
http://base4nfdi.de/ts4nfdi/schema/collectionIRIbecause some artefacts have a value forhttp://www.w3.org/2002/07/owl#versionIRIalready set (e.g., OLS uses the versionIRI property), which would then be overwritten.