feat(integrations): emit per-user rows from the Google Workspace employee-access check - #3352
Merged
Merged
Conversation
…oyee-access check One row per person (resourceType 'user', resourceId = lowercased email) instead of a single org-level row with the roster buried in evidence — person-scoped features join check results to org members by email. Role resolution, filtering, and pagination unchanged; a zero-user run still emits one org-level summary row. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013WLGUUjG6uLd6xvNhUpge1
…k-results-service Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013WLGUUjG6uLd6xvNhUpge1
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
The section referenced a skill file that lives outside the repo; inline the normative definition instead so the cross-reference isn't broken for repo readers. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013WLGUUjG6uLd6xvNhUpge1
Contributor
Author
|
Fixed — the referenced skill file lives outside this repo, so the section is now self-contained: the shape contract is defined inline and the broken cross-references are removed. |
claudfuen
pushed a commit
that referenced
this pull request
Jul 6, 2026
# [3.97.0](v3.96.1...v3.97.0) (2026-07-06) ### Bug Fixes * **people:** polish the redesigned People tab (requirement columns, filters, per-employee 2FA) ([#3347](#3347)) ([75758ec](75758ec)) ### Features * **integrations:** emit per-user rows from the Google Workspace employee-access check ([#3352](#3352)) ([0b54252](0b54252)) * **people:** access tab on member details, per connected integration ([#3349](#3349)) ([83f188c](83f188c)), closes [#2](https://github.com/trycompai/comp/issues/2)
Contributor
|
🎉 This PR is included in version 3.97.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Google Workspace
employee-accesscheck now emits one result row per person —resourceType: 'user',resourceId= lowercased email, with role/name/status details in each row's evidence — instead of a single org-level row with the whole roster buried in one evidence blob.Why
Person-scoped features join check results to org members by email (the People-tab 2FA column already works this way). The Employee Access task feeds the upcoming per-member Access view, which needs per-person rows to match people deterministically. This aligns the check with the same shape the 2FA checks use.
Notes
pass; task pass/fail behavior is unchanged.evidence.employees[]shape (checked both repos).Tests
New
employee-access.test.ts— per-user emission, lowercased email keying, role evidence, suspended-user filtering, zero-user summary row. Full package suite: 421 pass.🤖 Generated with Claude Code
https://claude.ai/code/session_013WLGUUjG6uLd6xvNhUpge1
Summary by cubic
Google Workspace
employee-accessnow emits one row per user (resourceType: 'user',resourceId= lowercased email) with role/name/status in evidence. Docs incheck-results-servicenow inline the standard person-scoped result shape; zero-user runs still emit a single org-level summary.Written for commit 4027d4a. Summary will update on new commits.