Skip to content

fix(common): volsync render error access modes string - #48578

Open
Spice-King wants to merge 3 commits into
trueforge-org:common2026from
Spice-King:fix/volsync-access-modes-string
Open

fix(common): volsync render error access modes string#48578
Spice-King wants to merge 3 commits into
trueforge-org:common2026from
Spice-King:fix/volsync-access-modes-string

Conversation

@Spice-King

@Spice-King Spice-King commented May 28, 2026

Copy link
Copy Markdown

Description

⚒️ Fixes volsync resources when the accessModes on the persistence object is set to a string. executing "tc.v1.common.lib.volsync.storage" at <$accessModes>: range can't iterate over ReadWriteOncePod

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code
  • 📜 Documentation Changes

🧪 How Has This Been Tested?

Added tests to cover accessModes being set to both a string and an array.

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made changes to the documentation
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning
  • I made sure the title starts with feat(chart-name):, fix(chart-name):, chore(chart-name):, docs(chart-name): or fix(docs):

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

@CLAassistant

CLAassistant commented May 28, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@Spice-King
Spice-King force-pushed the fix/volsync-access-modes-string branch from 04dc5d6 to 9613e74 Compare June 1, 2026 13:53
@Crow-Control
Crow-Control changed the base branch from master to common2026 June 3, 2026 09:57

@Crow-Control Crow-Control left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure its correctly rebase on common2026

@Spice-King
Spice-King force-pushed the fix/volsync-access-modes-string branch from 9613e74 to 4d0c188 Compare June 4, 2026 01:27
@Spice-King

Spice-King commented Jun 4, 2026

Copy link
Copy Markdown
Author

Rebased onto common2026, version bump commit dropped since common 2026 is not released anyway.
helps if I remember to commit the test fixes for common changes before pushing

@Spice-King
Spice-King requested a review from Crow-Control June 4, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants