fix(common): volsync render error access modes string - #48578
Open
Spice-King wants to merge 3 commits into
Open
Conversation
Spice-King
requested review from
Boemeltrein,
Crow-Control,
StevenMcElligott,
alfi0812,
stavros-k and
xstar97
as code owners
May 28, 2026 03:38
Spice-King
force-pushed
the
fix/volsync-access-modes-string
branch
from
June 1, 2026 13:53
04dc5d6 to
9613e74
Compare
Crow-Control
requested changes
Jun 3, 2026
Crow-Control
left a comment
Member
There was a problem hiding this comment.
Please ensure its correctly rebase on common2026
Spice-King
force-pushed
the
fix/volsync-access-modes-string
branch
from
June 4, 2026 01:27
9613e74 to
4d0c188
Compare
Author
|
Rebased onto |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
⚒️ Fixes volsync resources when the
accessModeson the persistence object is set to a string.executing "tc.v1.common.lib.volsync.storage" at <$accessModes>: range can't iterate over ReadWriteOncePod⚙️ Type of change
🧪 How Has This Been Tested?
Added tests to cover
accessModesbeing set to both a string and an array.📃 Notes:
✔️ Checklist:
feat(chart-name):,fix(chart-name):,chore(chart-name):,docs(chart-name):orfix(docs):➕ App addition
If this PR is an app addition please make sure you have done the following.
icon.pngPlease don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.