Skip to content

fix: point homebridge custom versioning at ghcr.io - #12

Open
Principe1218 wants to merge 1 commit into
trueforge-org:mainfrom
Principe1218:homebridge-ghcr
Open

fix: point homebridge custom versioning at ghcr.io#12
Principe1218 wants to merge 1 commit into
trueforge-org:mainfrom
Principe1218:homebridge-ghcr

Conversation

@Principe1218

Copy link
Copy Markdown

Description

⚒️ Fixes # N/A — companion to trueforge-org/truecharts#50995

trueforge-org/truecharts#50995 switches the homebridge chart's image.repository from docker.io/homebridge/homebridge to ghcr.io/homebridge/homebridge. The custom versioning rule for homebridge's date-based tags (YYYY-MM-DD treated as major.minor.patch) currently matches on matchPackagePatterns: ["docker.io/homebridge/homebridge"]. Once that PR merges, the pattern would stop matching the new package name, and Renovate would fall back to default SemVer versioning — which can't parse date tags — so future homebridge releases would silently stop being picked up again. This updates the pattern to match the new registry.

⚙️ Type of change

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code
  • 📜 Documentation Changes

🧪 How Has This Been Tested?

Reproduced Renovate's own matchPackagePatterns migration and regex-matching logic (from lib/config/migrations/custom/package-rules-migration.ts and lib/util/string-match.ts) locally in Node, and confirmed the updated pattern correctly matches ghcr.io/homebridge/homebridge and correctly excludes docker.io/homebridge/homebridge, homebridge/homebridge, etc.

Also pulled the live tag list from ghcr.io/homebridge/homebridge (425 tags) and ran the existing versioning regex against all of them: 91 correctly parse as dated releases (newest: 2026-07-31), the remaining 334 (-ubuntu, alpha-*, beta-*, named branches, etc.) are correctly excluded.

📃 Notes:

Not claiming this fixes whatever caused the year-long gap in homebridge update PRs before the registry switch (last one merged 2025-07-28) — I don't have visibility into this org's Renovate run history to diagnose that. This just avoids a second, new break from the registry switch in trueforge-org/truecharts#50995.

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made changes to the documentation
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning
  • I made sure the title starts with feat(chart-name):, fix(chart-name):, chore(chart-name):, docs(chart-name): or fix(docs): (this repo isn't a chart, so left unchecked — title instead follows this repo's own copilot-instructions.md convention: fix: ...)

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant