fix: point homebridge custom versioning at ghcr.io - #12
Open
Principe1218 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
⚒️ Fixes # N/A — companion to trueforge-org/truecharts#50995
trueforge-org/truecharts#50995 switches the homebridge chart's
image.repositoryfromdocker.io/homebridge/homebridgetoghcr.io/homebridge/homebridge. The custom versioning rule for homebridge's date-based tags (YYYY-MM-DDtreated as major.minor.patch) currently matches onmatchPackagePatterns: ["docker.io/homebridge/homebridge"]. Once that PR merges, the pattern would stop matching the new package name, and Renovate would fall back to default SemVer versioning — which can't parse date tags — so future homebridge releases would silently stop being picked up again. This updates the pattern to match the new registry.⚙️ Type of change
🧪 How Has This Been Tested?
Reproduced Renovate's own
matchPackagePatternsmigration and regex-matching logic (fromlib/config/migrations/custom/package-rules-migration.tsandlib/util/string-match.ts) locally in Node, and confirmed the updated pattern correctly matchesghcr.io/homebridge/homebridgeand correctly excludesdocker.io/homebridge/homebridge,homebridge/homebridge, etc.Also pulled the live tag list from
ghcr.io/homebridge/homebridge(425 tags) and ran the existing versioning regex against all of them: 91 correctly parse as dated releases (newest:2026-07-31), the remaining 334 (-ubuntu,alpha-*,beta-*, named branches, etc.) are correctly excluded.📃 Notes:
Not claiming this fixes whatever caused the year-long gap in homebridge update PRs before the registry switch (last one merged 2025-07-28) — I don't have visibility into this org's Renovate run history to diagnose that. This just avoids a second, new break from the registry switch in trueforge-org/truecharts#50995.
✔️ Checklist:
feat(chart-name):,fix(chart-name):,chore(chart-name):,docs(chart-name):orfix(docs):(this repo isn't a chart, so left unchecked — title instead follows this repo's owncopilot-instructions.mdconvention:fix: ...)➕ App addition
If this PR is an app addition please make sure you have done the following.
icon.pngPlease don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.