Skip to content

utlist: add CDL_CONCAT - #280

Closed
xunicatt wants to merge 2 commits into
troydhanson:masterfrom
xunicatt:master
Closed

utlist: add CDL_CONCAT#280
xunicatt wants to merge 2 commits into
troydhanson:masterfrom
xunicatt:master

Conversation

@xunicatt

Copy link
Copy Markdown
Contributor

Add missing CDL_CONCAT macro for circular doubly-linked lists to match LL_CONCAT and DL_CONCAT.
This fills the API gap noted in issue #279.

@Quuxplusone

Copy link
Copy Markdown
Collaborator

Ack — will take a look sometime soon.
I recently revamped the PREPEND and PREPEND_ELEM test (test86) to be "chummier with the implementation." I think I'd like to see the CONCAT tests (test63 and test64) combined with your new test to use that same style. I'm not sure if that's a good use of your time, though, or if I should just find time to do it myself.

@xunicatt

Copy link
Copy Markdown
Contributor Author

Ack — will take a look sometime soon. I recently revamped the PREPEND and PREPEND_ELEM test (test86) to be "chummier with the implementation." I think I'd like to see the CONCAT tests (test63 and test64) combined with your new test to use that same style. I'm not sure if that's a good use of your time, though, or if I should just find time to do it myself.

Yup I can implement a test like that.

Rewrite CONCAT tests to use assertion-based, test86-style structure,
and combine the previous LL (test63) and DL (test64) tests into test103.
@xunicatt

Copy link
Copy Markdown
Contributor Author

Hey @Quuxplusone, would you mind taking a look at this when you have time?

Quuxplusone added a commit that referenced this pull request May 28, 2026
Thanks to xunicatt for the patch!
@Quuxplusone

Copy link
Copy Markdown
Collaborator

Merged 5ada598 — thanks!
(I rewrote the unit test in the style I was aiming for. The "utlist.h" change remains the same as what you had, which LGTM.)

@Quuxplusone Quuxplusone mentioned this pull request May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants