Add LL_REVERSE/DL_REVERSE/CDL_REVERSE macros to utlist - #278
Closed
xunicatt wants to merge 10 commits into
Closed
Conversation
xunicatt
marked this pull request as draft
March 12, 2026 06:14
xunicatt
changed the title
LL_REVERSE/DL_REVERSE macros to utlistLL_REVERSE/DL_REVERSE/CDL_REVERSE macros to utlist
Contributor
Author
|
Sorry for the previous commit message formatting, the backticks were eaten by my shell while committing from terminal. |
xunicatt
marked this pull request as ready for review
March 12, 2026 07:15
Quuxplusone
reviewed
Mar 12, 2026
Quuxplusone
left a comment
Quuxplusone
left a comment
Collaborator
There was a problem hiding this comment.
At first glance this looks very good!
I haven't checked it out and run the tests or really gone over the code, but in this brief online review I'm not seeing any red flags. Will take a closer look Real Soon Now.
Contributor
Author
|
Thanks for the feedback! I've updated the PR and fixed the issues you mentioned. Let me know if anything else needs to be changed. |
Quuxplusone
reviewed
Mar 17, 2026
Quuxplusone
added a commit
to Quuxplusone/uthash
that referenced
this pull request
Mar 18, 2026
Thanks to xunicatt for the patch!
Collaborator
|
Merged as 6d85739 (with different test coverage) — thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
LL_REVERSE/LL_REVERSE2,DL_REVERSE/DL_REVERSE2andCDL_REVERSE/CDL_REVERSE2macros toutlist.h, along with documentation, updates and tests.Reversing a list is a common operation when building lists using
LL_PREPENDin a loop and reversing at the end instead of repeatedly using
LL_APPEND.This usage pattern was mentioned in #197 and #263.