Open
Conversation
Sunny6889
commented
Mar 11, 2026
| # Uses GitHub OIDC provider to assume an IAM role with short-lived credentials. | ||
| # No static keys needed — credentials expire after the workflow run. | ||
| # Prerequisites: | ||
| # 1. Create an IAM OIDC identity provider for token.actions.githubusercontent.com |
Contributor
Author
There was a problem hiding this comment.
this workflows actually not used yet, so just modify the file and configure later
3for
reviewed
Mar 11, 2026
3for
reviewed
Mar 11, 2026
| # Address: TPL66VK2gCXNCD7EJg9pgJRfqcRazjhUZY | ||
| # WARNING: Replace with your own generated key for any real deployment | ||
| # NEVER use this key on mainnet with real funds | ||
| da146374a75310b9666e834ee4ad0866d6f4035967bfc76217c5a495fff9f0d0 # you must enable this value and the witness address are match. |
Contributor
There was a problem hiding this comment.
Replace with YOUR_PRIVATE_KEY_HERE_64_CHARACTERS_HEXADECIMAL_STRING_EXAMPLE？
Contributor
Author
There was a problem hiding this comment.
better not, because it will cause user cannot start the demo easily. I already mention it in related readme.
| # Address: TCjptjyjenNKB2Y6EwyVT43DQyUUorxKWi | ||
| # WARNING: Replace with your own generated key for any real deployment | ||
| # NEVER use this key on mainnet with real funds | ||
| 0ab0b4893c83102ed7be35eee6d50f081625ac75a07da6cb58b1ad2e9c18ce43 # you must enable this value and the witness address are match. |
Contributor
There was a problem hiding this comment.
Replace with YOUR_PRIVATE_KEY_HERE_64_CHARACTERS_HEXADECIMAL_STRING_EXAMPLE？
Contributor
Author
There was a problem hiding this comment.
same as above, for user quick-start
3for
reviewed
Mar 12, 2026
| @@ -3,11 +3,14 @@ services: | |||
| grafana: | |||
| image: grafana/grafana-oss | |||
Contributor
There was a problem hiding this comment.
Missing docker image version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details