Repository navigation
feat: support env strings config-wide - #1221
Merged
Merged
Conversation
Signed-off-by: James Ranson <james@ranson.org>
LimitlessEarth
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This expands environment var string replacement to all YAML values, rather than just specific values typed as
EnvString. Instead of interpolating${ENV_NAME}forEnvStringfields during YAML unmarshaling, this change finds and interpolates all${ENV_NAME}values across the config prior to the unmarshal step, while theEnvStringandEnvStringMaptypes are retired.The
secret.Secretremains as a string type variant that returns<secret>fromString(), and additional fields (e.g., redis credentials) are chnaged to Secret to prevent spilling in the sanitized config.Because Request Rewriters use the
${1}or${genericCaptureFieldname}formats for regex captures, that section requires env values to start withTRK_(e.g,.${TRK_REWRITER_FALLBACK_BACKEND}) to interpolate. TheTRK_prefix requirement does not apply to config sections outside of Request Rewriters.Type of Change
AI Disclosure