Skip to content

First draft Rule/check PRs - #1172

Draft
roger-95s wants to merge 5 commits into
trickstercache:mainfrom
roger-95s:rule/check
Draft

roger-95s wants to merge 5 commits into
trickstercache:mainfrom
roger-95s:rule/check

Conversation

@roger-95s

@roger-95s roger-95s commented Oct 1, 2026 •

Copy link
Copy Markdown

Description

Removed custom Linter cofigurations in .golangci.yml to allow all enabled linters to run using their default settings, and enabled the lll linter with line-length: 180 now is enable with its default line-length.

*Note.*Running linters with default configurations flagged 97 issues. [This is PR is raised as a draft to discuss how we want to address Chore: Expand Linting]

Type of Change

    • Bug fix
    • New feature
    • Optimization
    • Test coverage
    • Documentation
    • Infrastructure

AI Disclosure

    • This contribution DOES NOT include AI-generated changes
    • This contribution DOES include AI-generated changes, and I have reviewed the relevant contributing guidelines.

@jranson

jranson commented Oct 1, 2026

Copy link
Copy Markdown
Member

@roger-95s it looks like the DCO check has failed. On your commits, be sure to use --signoff (e.g., git commit --signoff -m 'my commit message') since the CNCF (sponsoring foundation) requires that for all contributions. You'll need to amend your previous commits and force push.

Signed-off-by: roger-95s <rogeresleitercc@gmail.com>
Signed-off-by: roger-95s <rogeresleitercc@gmail.com>
@roger-95s

Copy link
Copy Markdown
Author

Yes, I just noted that I did not signoff my commit. I forced push to overwrite the branch.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants