test(sdk): cover waitForConfirmation polling and timeout#371
Open
giftexceed wants to merge 1 commit into
Open
Conversation
waitForConfirmation is on the critical path for every payment UI but had no test coverage. Add tests that stub the RPC server's getTransaction and exercise the four behaviours: immediate success, immediate failure, a pending response followed by success (polling), and throwing once the timeout deadline passes. Closes tributary-protocol#334
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds test coverage for
waitForConfirmationinsdk/src/index.ts, which polls RPC for a transaction's status and previously had none. It's small but on the critical path for every payment UI.Tests
The RPC server's
getTransactionis stubbed (viat.mock.methodonrpc.Server.prototype, auto-restored per test) so no network is used. Poll/timeout values are tiny so the suite runs in milliseconds. Coverage:NOT_FOUNDresponse is polled past untilSUCCESSarrives (verifies polling).Notes
npm run buildandnpm testpass insdk/.Closes #334