feat(app): add app-wide error boundary#315
Open
onajidavid87-web wants to merge 1 commit into
Open
Conversation
Adds a React Error Boundary at the root of the render tree to prevent uncaught runtime/render errors (e.g. the BigInt crash in tributary-protocol#266) from blanking the entire UI. - New `ErrorBoundary` class component wrapping the app outside `<StrictMode>` - Fallback UI shows the error message with "Try again" (resets boundary) and "Refresh page" recovery actions - Styled to match existing design system - 4 tests covering normal rendering, fallback display, reset, and error logging Closes tributary-protocol#148
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148
What this changes
Adds a React Error Boundary at the root of the render tree to prevent uncaught runtime/render errors
Why
New
ErrorBoundaryclass component wrapping the app outside<StrictMode>Fallback UI shows the error message with "Try again" (resets boundary) and "Refresh page" recovery actions
Styled to match existing design system
4 tests covering normal rendering, fallback display, reset, and error logging
Checklist
cargo fmt --allandcargo clippy --all-targets -- -D warningspasscargo testpassesNew behavior has tests
Linked issue, if there is one
Closes #148