Uml diagrams documentation#3
Open
tretikoff wants to merge 4 commits into
Open
Conversation
FirstTimeInForever
requested changes
Apr 15, 2021
Collaborator
FirstTimeInForever
left a comment
FirstTimeInForever
left a comment
There was a problem hiding this comment.
-
На диаграмме случаев использования стоит убрать файловую систему. Не очень понятно что такое "Получить доп. информацию".
-
На диаграмме последовательностей нужно добавить пунктирные вертикальные линии от объектов к последовательностям пример.
-
На диаграмме компонентов Stream, не должен быть отдельным компонентом т. к. он является интерфейсом, который связывает команды и Shell. Тоже самое про Command - вместо него нужно показать конкретные команды, которые связаны через интерфейс Command с фабрикой. Фабрика связывается с Shell через интерфейс Command и Word (Word тоже следует убрать и оставить как интерфейс). пример.
5/6.
FirstTimeInForever
approved these changes
May 1, 2021
Collaborator
FirstTimeInForever
left a comment
FirstTimeInForever
left a comment
There was a problem hiding this comment.
Выглядит окей.
6/6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.