grep#2
Open
tretikoff wants to merge 5 commits into
Open
Conversation
tretikoff
force-pushed
the
grep-command
branch
from
3095b35 to
b2c9154
Compare
tretikoff
force-pushed
the
solution
branch
2 times, most recently
from
e9ab00a to
386fa0c
Compare
tretikoff
force-pushed
the
grep-command
branch
from
ac82bbc to
f0c2131
Compare
tretikoff
force-pushed
the
solution
branch
5 times, most recently
from
31bf5b7 to
fbcb94e
Compare
tretikoff
force-pushed
the
grep-command
branch
2 times, most recently
from
ff21afe to
047f1f0
Compare
FirstTimeInForever
requested changes
Feb 27, 2021
Collaborator
There was a problem hiding this comment.
Отказывается принимать ключи:
$grep -A 10 test README.md
Feb 27, 2021 9:10:45 PM ru.tretikoff.Shell run
INFO: grep -A 10 test README.md
Feb 27, 2021 9:10:45 PM ru.tretikoff.Parser splitByQuotes
INFO: parsing grep -A 10 test README.md from the -1 to the -1
Feb 27, 2021 9:10:45 PM ru.tretikoff.Parser parse
INFO: Splitted grep -A 10 test README.md by quotes [grep -A 10 test README.md]
Feb 27, 2021 9:10:45 PM ru.tretikoff.Parser parse
INFO: Splitted grep -A 10 test README.md into [grep, -A, 10, test, README.md]
Feb 27, 2021 9:10:45 PM ru.tretikoff.Shell run
INFO: grep, -A, 10, test, README.md
Feb 27, 2021 9:10:45 PM ru.tretikoff.words.Word substituteVariables
INFO: sadg
Feb 27, 2021 9:10:45 PM ru.tretikoff.words.Word substituteVariables
INFO: sadg
Feb 27, 2021 9:10:45 PM ru.tretikoff.words.Word substituteVariables
INFO: sadg
Feb 27, 2021 9:10:45 PM ru.tretikoff.words.Word substituteVariables
INFO: sadg
Feb 27, 2021 9:10:45 PM ru.tretikoff.words.Word substituteVariables
INFO: sadg
Feb 27, 2021 9:10:45 PM ru.tretikoff.Shell run
SEVERE: grep: unrecognized option '-A'
grep: unrecognized option '-A'
По заданию нужно ещё поддерживать поиск по regex (достаточно делать это по ключу -e). Добавьте пожалуйста regex, поправьте аргументы и CI.
Owner
Author
|
@FirstTimeInForever я думал что поддерживать регулярные выражения нужно без специальных ключей. Они добавлены, на это даже тесты есть. Тем более в задании про ключ -e ничего не сказано, сказано поддержать регулярки в строке поиска С ключами прошу прощения, после ребейза перестали некоторые работать, поэтому тесты завалились (плюс подразумевалось использование ключа как -A10, переделал чтобы -A 10 тоже работало) |
tretikoff
force-pushed
the
grep-command
branch
4 times, most recently
from
32b473e to
706f5d5
Compare
Collaborator
FirstTimeInForever
left a comment
FirstTimeInForever
left a comment
There was a problem hiding this comment.
Зависает на пайпе: $cat README.md | grep grep.
Owner
Author
|
Да, действительно, читал из нового ConsoleStream вместо inputStream, из-за этого pipe не работал. Исправил |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.