Skip to content

Conversation

@koppor
Copy link

@koppor koppor commented Sep 22, 2019

This fixes #1105.

On "Git Bash" on Windows, the dpl executable runs cmd.exe, which does not play well with the bash syntax. Thus, I added a check to be on Windows and then execute bash.exe.

This required

  • new dependency on os to check for Windows
  • reroute calls from Kernel.system to shell

I also fixed the setup phase. The git config command was called inside the source directory (which typically is not a .git directory) and not in the target directory (which is the git repository being pushed).

Tested on Windows with a GitHub repository.

Minor fix: typo

@koppor
Copy link
Author

koppor commented Sep 22, 2019

fa80748 also shows the change of the order. The issue is that git config --global is not used and thus the git config command was executed in the directory which should be uploaded. That directory is not necessarily a git directory: With dpl, I can upload arbitrary directories to gh-pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload to gh-pages on Windows leads to "failed to deploy"

1 participant